plus3it / plus3it/amigen8

[BUG] PostBuild.sh script's "NO TMPFS" option can make script go out to lunch

Open Beginner friendly
#54 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Shell
Stars
10
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

Depending on flag-ordering, specifying the --no-tmpfs toggle-flag can make the PostBuild.sh script hang during command-line argument-processing

Severity

Nuisance: this flag is rarely used.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Specification of flag results in AMI being built without the tmp.mount option being activated.

Deviance Description

Script hangs during option-parsing.

Fix Suggestions

Fix option-handling in:

       --no-tmpfs)
             NOTMPFS="true"
             ;;

Section (lines 501-503). Presumably add a shift statement before the switch-option stanza-close.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in PostBuild.sh around lines 501-503, specifically the --no-tmpfs option stanza, and inspect how arguments are consumed during option parsing. Reproduce the hang with different flag orderings, then verify that --no-tmpfs completes parsing and builds the AMI without activating tmp.mount.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system, cloud, devops
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.