plotly / plotly/plotly_matlab

Error hiding for missing credentials

Open
#119 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
MATLAB
Stars
413
Forks
166
PR merge metrics
No merged PRs in 30d

Description

If the credentials do not exist, MATLAB-online hides the Plotly:CredentialsNotFound error with plotlyfigConstructor:notSignedIn because of a try/catch.

https://github.com/plotly/MATLAB-Online/blob/72b22f5ce8572118e8447189f472a7ad58d78760/plotly/plotlyfig.m

            %-UserData-%
            try
                [obj.UserData.Username,...
                    obj.UserData.ApiKey,...
                    obj.UserData.PlotlyDomain] = signin;
            catch
                errkey = 'plotlyfigConstructor:notSignedIn';
                error(errkey, plotlymsg(errkey));
            end

If we are running with offline capability, it would be very exceptionally nice to not need any config/credential files at all. Encountered this when I was investigating an issue with the plotly/MATLAB-Online API ( #https://github.com/imatlab/imatlab/issues/13)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read plotly/plotlyfig.m at the signin call and examine how its try/catch maps missing credentials to plotlyfigConstructor:notSignedIn. Compare that behavior with the offline-capability requirement and the referenced imatlab issue. Done means missing credential files no longer hide the underlying credentials error or prevent the intended offline use.

Written by the indexing model from the issue text.

Assessment

Tech stack
matlab
Domain
authentication, data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.