Line width = 0 in templates effectively disables hline and vline
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 18.8k
- Forks
- 2.8k
- Avg merge
- 16h 26m
- Merged PRs (30d)
- 21
Description
Three of the templates, ggplot2, simple_white and seaborn have line width set to 0.
https://github.com/plotly/plotly.py/blob/743b52484f47c518b85a04027c1b393528f44c15/packages/python/plotly/templategen/definitions.py#L44
https://github.com/plotly/plotly.py/blob/743b52484f47c518b85a04027c1b393528f44c15/packages/python/plotly/templategen/definitions.py#L95
https://github.com/plotly/plotly.py/blob/743b52484f47c518b85a04027c1b393528f44c15/packages/python/plotly/templategen/definitions.py#L223
This causes the add_hline and add_vline methods to not appear by default when using these templates, and the line_width property has to be set manually. I'm proposing that these templates have a thin line width value to enable vlines and hlines by default.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/python/plotly/templategen/definitions.py at the referenced lines for the ggplot2, simple_white, and seaborn templates. Check how their zero line widths affect add_hline and add_vline, then verify that a thin default line enables both methods without requiring line_width to be set manually.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100