[BUG]: Custom SVG images don't render on modebar correctly
Open
Nobody has claimed this yet.
bug
regression
- Dominant language
- JavaScript
- Stars
- 18.3k
- Forks
- 2k
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 28
Description
Description
SVG images with multiple paths used as modebar icon don't color correctly since 3.0.0.
I noticed the "fill" style is only set on the initial path element, not all of them.
Screenshots/Video
"SVG" image
Steps to reproduce
https://jsfiddle.net/m1x7unsf/1/
Notes
It works fine up through 2.35.3, breaks in 3.0.0.
I believe the cause is 46ea43c1a155cc8981919840f8851b31cb938d13.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the linked JSFiddle and compare the modebar SVG behavior with version 2.35.3, then inspect commit 46ea43c1a155cc8981919840f8851b31cb938d13. Done means custom SVG icons with multiple paths receive consistent coloring in version 3.0.0 and later.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data-visualization, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 46/100