plotly / plotly/plotly.js

Locale dictionary not being included even though they exist

Open
#7,450 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P1
Dominant language
JavaScript
Stars
18.3k
Forks
2k
Avg merge
2d 12h
Merged PRs (30d)
28

Description

I have included several of the Plotly Locales in my project before (es, pt-br, zh-ch, ar) and now I am trying to include Norwegian (no) but the translations dictionary is not working when setting "no" as the locale. The dictionary is returning an empty object.
The formatting is working and the dates and times are being translated to norwegian as they should be, but the modebar buttons are remaining english even though the dictionary translations are included in the plotly.js/lib/locales/no.js file.

I tested this with a couple of other languages to check that I wasn't missing something and the same problem occurs if I try to use romanian (ro) - the formatting is correct and present, but the dictionary translations are not working even though they are included in the file.

Image shows the plotly config including several languages, see that the Spanish (es) locale shows the occupied dictionary translations as it should, but the Norwegian (no) locale shows an empty object for the dictionary, however, includes the formats.
Image

Summary:
Norwegian locale dictionary is not working (returning empty objects when importing) even though the translations are included in plotly.js/lib/locales/no.js. Same problem occurs with Romanian - possibly others.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/locales/no.js and compare its exported dictionary and formats with the working es locale. Reproduce the issue using the no and ro locales, then trace how locale dictionaries are imported or registered. Done means the no and ro dictionaries are populated and their modebar translations are applied, while formatting remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.