plotly / plotly/plotly.js

Custom bundle doesn't generate CSS file anymore.

Open
#7,258 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P2
Dominant language
JavaScript
Stars
18.3k
Forks
2k
Avg merge
2d 12h
Merged PRs (30d)
28

Description

When generating a custom bundle, no CSS file is generated any more, even though it's mentioned in the output.

Steps to reproduce

$ git clone https://github.com/plotly/plotly.js.git
$ cd plotly.js
$ git checkout e6b155c1c91603eb0946f111bc3415b222422230
$ npm install
$ npm run custom-bundle -- --traces sunburst --transforms none --strict --out sunburst
> plotly.js@2.35.2 custom-bundle
> node tasks/custom_bundle.mjs --traces sunburst --transforms none --strict --out sunburst

{
  traceList: [ 'scatter', 'sunburst' ],
  name: 'sunburst',
  index: '/users/tkm/dhauck/kekse/plotly.js/lib/index-strict-sunburst.js',
  strict: true,
  dist: '/users/tkm/dhauck/kekse/plotly.js/dist/plotly-sunburst.js',
  distMin: '/users/tkm/dhauck/kekse/plotly.js/dist/plotly-sunburst.min.js'
}

  dist/plotly-sunburst.min.js    1.0mb ⚠️
  dist/plotly-sunburst.min.css  63.9kb

⚡ Done in 750ms

This results in the following extra files being generated:

$ git clean -dxn
Would remove dist/plotly-sunburst.min.js
Would remove lib/index-strict-sunburst.js
Would remove node_modules/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tasks/custom_bundle.mjs and reproduce the documented npm run custom-bundle command at commit e6b155c1c91603eb0946f111bc3415b222422230. Compare the generated dist/plotly-sunburst.min.js and expected CSS output with git clean -dxn; done means the custom bundle generates the CSS file mentioned in the build output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.