plotly / plotly/plotly.js

Locale Partially Effective: Dictionary Errors in pt-BR, pt-PT, and ko

Open
#6,256 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P2
Dominant language
JavaScript
Stars
18.3k
Forks
2k
Avg merge
2d 12h
Merged PRs (30d)
28

Description

I tried to find an open or closed issue that addresses this and didn't find one. I've been around GitHub, but whether this should be a discussion, pull request, or something else...I'm not all that knowledgeable about where this belongs.

This was brought to my attention through an SO question for the R version, but it's also an issue in Plotly JS. The question is here. The person that asked that question added it to a current issue for that version of Plotly. You can see that here. I realized what was wrong when I compared the language pt-BR to other languages that rendered correctly (de or es, for example).

Wherever dictionary words are rendered with a colon, it is incorrect both in English and the locale language. For example, median: "mediana". This should be "median:":"mediana:" for this to work.

If I've caught them all, these are the English versions that are documented incorrectly (set up for a copy, paste, and regex):
'close',0'high','incoming flow count','kde', 'lat', 'lon','low','lower fence': 'limite inferior','max','mean ± σ','mean','median','min','new text','open','outgoing flow count','q1','q3','source','target','upper fence'

It looks like pt-br, pt-pt, and ko.js have this issue. I just did a find-grep for ',median:'.

This example, using pt-BR (and an example on the Plotly JS site), appears to render correctly, but that's because none of the errors in the JS are shown.

If you look at the tooltips or label with a colon in this CodePen, you'll see the issue.

image

From this CodePen, It should look like this:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the locale dictionaries for pt-BR, pt-PT, and ko.js, starting with a search for dictionary keys such as median that are rendered with colons. Compare the affected entries with the English versions and the listed examples. Done means colon-bearing labels render correctly in the reported tooltips and labels for all three locales.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.