plotly / plotly/plotly.R

plotlyMainBundle does not support partial_bundle minified = FALSE

Open
#2,479 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

As the title describes, when using "auto" (defaulting to main) or directly using "main" when calling partial_bundle(), the "minified" argument is lost and the result always uses the minified plotly-latest.min.js

FWIW it might also be better to adhere to the shiny.minified option rather than having to call partial_bundle() at all.

Discovered while tracing a javascript issue with plotlyProxy relayout.

plotly R version: 4.12.0
plotly js version: 2.25.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the R package's partial_bundle() entry point, tracing the auto and main bundle selection and how minified is passed through. Exercise both modes with minified = FALSE and verify that the resulting asset is not plotly-latest.min.js; check the package's relevant tests for where this behavior belongs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, r
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.