plotly / plotly/plotly.R

Make `event_data` warning suppressable?

Open
#2,278 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

Hi plotly devs,

The current implementation for event_data makes it such that the warning will display in nearly all instances where UI is rendered dynamically (such as in a shiny app). The warning is attached as a callback to the onFlush event which prevents it from being suppressed with suppressWarnings.

Can either:

  • A vignette be provided for how to implement event_data with dynamically rendered UI in a modular shiny app without triggering the warning? -OR-
  • An argument be provided to event_data to suppress the warning?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with R/shiny.R around line 151 and trace how event_data attaches the warning to the onFlush event during dynamically rendered Shiny UI. Compare the two requested outcomes: document modular usage in a vignette or provide an event_data option that suppresses the warning; done means one of these paths is implemented and its behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.