plotly / plotly/plotly.R

Shouldn't s2 be as Suggested package?

Open
#2,203 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

It's required to run some tests, e.g.

https://github.com/plotly/plotly.R/blob/f9d6e43ff42760e84113992eb9711bc4fcbcf203/tests/testthat/test-ggplot-sf.R#L4

By the reasoning in WRE, that makes s2 Suggests:

All packages that are needed to successfully run R CMD check on the package must be listed in one of ‘Depends’ or ‘Suggests’ or ‘Imports’. Packages used to run examples or tests conditionally... should be listed in ‘Suggests’ or ‘Enhances’.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/testthat/test-ggplot-sf.R at line 4 and inspect the package dependency metadata, then compare the requirement with the WRE guidance on package dependencies. Update the classification if appropriate and run R CMD check to verify the tests and dependency declarations work correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.