plotly / plotly/plotly.R

how about removing function last_plot?

Open
#1,943 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

plotly depends on ggplot2 which alreadly has loaded function last_plot(), so, maybe we can throw it away as ggridge did


Brief description of the problem

library(plotly)
#> Loading required package: ggplot2
#> 
#> Attaching package: 'plotly'
#> The following object is masked from 'package:ggplot2':
#> 
#>     last_plot
#> The following object is masked from 'package:stats':
#> 
#>     filter
#> The following object is masked from 'package:graphics':
#> 
#>     layout
plotly::last_plot
#> function () 
#> .store$get()
#> <bytecode: 0x7f9575ad7558>
#> <environment: namespace:plotly>
ggplot2::last_plot
#> function () 
#> .store$get()
#> <bytecode: 0x7f9575ad5cd8>
#> <environment: namespace:ggplot2>

Created on 2021-04-19 by the reprex package (v2.0.0)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the public plotly::last_plot and ggplot2::last_plot entry points shown in the report, then inspect how plotly exposes or tests last_plot. Determine the existing package behavior and test coverage before removing the duplicate; done means plotly no longer masks ggplot2's last_plot without breaking supported usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.