plotly / plotly/plotly.R

Implementation of ggalt::geom_encircle()

Open
#1,658 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ggplotly good-for-first-time-contribution
Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

Good evening,

  • I will say first thank for the awesome packages and more for the R community, this is just awesome !

  • I have found a topic yet not covered by the plotly package. You will find bellow a reprex with the error message.

library(magrittr)
library(ggplot2)
gp <- iris %>% 
        ggplot(. , aes(x = Sepal.Length, y = Sepal.Width, colour = Species)) +
        geom_point() +
        ggalt::geom_encircle()
plotly::ggplotly(gp)

Warning messages:
1: In geom2trace.default(dots[[1L]][[3L]], dots[[2L]][[1L]], dots[[3L]][[1L]]) :
  geom_GeomEncircle() has yet to be implemented in plotly.
  If you'd like to see this geom implemented,
  Please open an issue with your example code at
  https://github.com/ropensci/plotly/issues
2: In geom2trace.default(dots[[1L]][[3L]], dots[[2L]][[1L]], dots[[3L]][[1L]]) :
  geom_GeomEncircle() has yet to be implemented in plotly.
  If you'd like to see this geom implemented,
  Please open an issue with your example code at
  https://github.com/ropensci/plotly/issues
3: In geom2trace.default(dots[[1L]][[3L]], dots[[2L]][[1L]], dots[[3L]][[1L]]) :
  geom_GeomEncircle() has yet to be implemented in plotly.
  If you'd like to see this geom implemented,
  Please open an issue with your example code at
  https://github.com/ropensci/plotly/issues

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the provided R reprex with ggplot2, ggalt::geom_encircle(), and plotly::ggplotly(), then inspect the geom2trace.default path named in the warning. Done means the example no longer warns that geom_GeomEncircle() is unimplemented and the encircled plot renders through plotly.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.