plotly / plotly/plotly.R

handle aes( ... = NULL) appropriately

Open
#1,139 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority: low
Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

ggplotly does not accept aesthetics with NULL assignment.
Use case in a programmatic big app I have a code that assigns aesthetics globally then turn off the aesthetics for some layers.
There are some workarounds but my issue I am filing in here is to handle correctly the aes ( ... = NULL)

require(ggplot2)
require(plotly)

plottest<- ggplot(mtcars,aes(mpg,disp))+
  aes(group=cyl)+
  geom_line()+
  geom_smooth(aes(group=NULL))

ggplotly(plottest)

plotfixed<- ggplot(mtcars,aes(mpg,disp))+
  geom_line(aes(group=cyl) )+
  geom_smooth()

ggplotly(plotfixed)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied R examples with ggplot2 and plotly, comparing the global group aesthetic with the layer using aes(group=NULL). Trace how ggplotly handles that layer and verify that the NULL assignment disables the inherited aesthetic without breaking conversion.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.