Extract graph schema validation into properly named test
Open
Beginner friendly
Nobody has claimed this yet.
good first issue
P3
size: 1
task
- Dominant language
- Python
- Stars
- 24.4k
- Forks
- 2.3k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 13
Description
In test: test_tagr002_tabs_render_without_selected we do
# do some extra tests while we're here
# and have access to Graph and plotly.js
check_graph_config_shape(dash_dcc)
This check that we have all the props defined, but the test is random and parametrized so the same check is run twice. It should be in it's own test.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for test_tagr002_tabs_render_without_selected and inspect its call to check_graph_config_shape(dash_dcc). Move the graph schema check into a separately named test, then verify the original parametrized test no longer runs it twice and that the new test covers the same validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100