plotly / plotly/dash

customized x-csrftoken contains extra `undefined`

Open
#3,114 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P2
Dominant language
Python
Stars
24.4k
Forks
2.3k
Avg merge
2d 7h
Merged PRs (30d)
13

Description

When customizing the x-csrftoken field for requests sent from the browser based on hooks, the actual field value obtained on the backend always contains extra undefined content. This issue does not occur when setting other fields.

Image

import dash
from dash import html
from flask import request
from dash.dependencies import Input, Output

app = dash.Dash(
    __name__,
    hooks={
        "request_pre": """
(payload) => {
    store.getState().config.fetch.headers['x-csrftoken'] = 'test-extra-header-value'
    store.getState().config.fetch.headers['other-field'] = 'other-value'
}
"""
    },
)

app.layout = html.Div(
    [html.Button("test", id="test-input"), html.Br(), html.Span(id="test-output")],
    style={"padding": 50},
)


@app.callback(Output("test-output", "children"), Input("test-input", "n_clicks"))
def test_callback(n_clicks):
    return "x-csrftoken: {}  other-field: {}".format(
        request.headers.get("x-csrftoken"), request.headers.get("other-field")
    )


if __name__ == "__main__":
    app.run(debug=True)

dash                 2.18.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied Dash 2.18.2 reproduction, then inspect how the request_pre hook updates fetch headers before the browser request reaches Flask. Done means the backend receives the customized x-csrftoken value without extra undefined content, while other-field still retains its configured value.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, javascript, python
Domain
backend-api-design, full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.