plotly / plotly/dash

Add ability to specify order of components when using pattern-matching wildcards (ALL)

Open
#2,834 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

cs feature P1
Dominant language
Python
Stars
24.4k
Forks
2.3k
Avg merge
2d 7h
Merged PRs (30d)
13

Description

When pattern matching callbacks are used with 2 or more key-value pairs and the ALL keyword, Dash passes the list of Inputs to the callback function in the order in which they are created, instead of listing all of the elements of the first group, then the second group, etc. (see full examples at the end of the issue)

For example, if we create something with ids like:

{'type': 'button', 'card_number': card_idx, 'index': i}

and we use ALL for both card_idx and i in the callback decorator (to get their values/children/whatever), we get a list, that summarised looks like:

['card0_button0', 'card0_button1', 'card1_button0', 'card1_button1']

which is easy enough to work with. However, if buttons are added to the first card (or any except the last), then the order will be:

['card0_button0', 'card0_button1', 'card1_button0', 'card1_button1', 'card0_button2'] 

The expected output would be:

['card0_button0', 'card0_button1', 'card0_button2', 'card1_button0', 'card1_button1'] 

Describe the solution you'd like

Something like a sort_by argument for Input/Output/State that allows developers to specify the id dict key they want to use to sort the Inputs/States when using ALL.

Input({'type': 'button', 'card_number': card_idx, 'index':ALL}, 'n_clicks', sort_by='card_number')

It could also be a list, like:

Input({'type': 'button', 'card_number': card_idx, 'index':ALL}, 'n_clicks', sort_by=['card_number', 'index'])

Sample apps

To replicate current behaviour:

import dash
from dash import Dash, dcc, html, Input, Output, State, callback
from dash import ALL, MATCH, Patch, ctx

app = Dash(__name__)

app.layout = html.Div([
    html.Div(
        id={'type': 'card', 'card_number': card_idx},
        children = [
            html.Button(
                id={'type': 'add', 'card_number': card_idx},
                children='Add new button'
            ),
            html.Button(
                id={'type': 'button', 'card_number': card_idx, 'index': 0},
                children=f"card{card_idx}_button0"
            )
    ]) for card_idx in range(1,4)
] + [
    html.Div(id='out', children='No button clicked yet')
])

@callback(
    Output({'type': 'card', 'card_number': MATCH}, 'children'),
    Input({'type': 'add', 'card_number': MATCH}, 'n_clicks'),
    prevent_initial_call=True
)
def add_button_to_card(n_clicks):
    card_idx = ctx.triggered_id['card_number']
    card_children = Patch()
    card_children.append(
        html.Button(
                id={'type': 'button', 'card_number': card_idx, 'index': n_clicks},
                children=f"card{card_idx}_button0"
            )
    )
    return card_children

@callback(
    Output('out', 'children'),
    Input({'type': 'button', 'card_number': ALL, 'index':ALL}, 'n_clicks'),
    prevent_initial_call=True
)
def print_inputs(buttons):
    return str(ctx.inputs_list)

if __name__ == "__main__":
    app.run_server(debug=True)

Workaround (it only works if the broader/higher-level category has a pre-defined number of items)

@callback(
    Output('out', 'children'),
    [Input({'type': 'button', 'card_number': card_idx, 'index':ALL}, 'n_clicks') for card_idx in range(1,4)],
    prevent_initial_call=True
)
def print_inputs(buttons_c1, buttons_c2, buttons_c3):
    return str(ctx.inputs_list)

Workaround variation with flexible callback signatures:

import dash
from dash import Dash, dcc, html, Input, Output, State, callback
from dash import ALL, MATCH, Patch, ctx

app = Dash(__name__)

app.layout = html.Div([
    html.Div(
        id={'type': 'card', 'card_number': card_idx},
        children = [
            html.Button(
                id={'type': 'add', 'card_number': card_idx},
                children='Add new button'
            ),
            html.Button(
                id={'type': 'button', 'card_number': card_idx, 'index': 0},
                children=f"card{card_idx}_button0"
            )
    ]) for card_idx in range(1,4)
] + [
    html.Button(id='lonely_button', children='lonely button'),
    html.Div(id='out', children='No button clicked yet')
])

@callback(
    Output({'type': 'card', 'card_number': MATCH}, 'children'),
    Input({'type': 'add', 'card_number': MATCH}, 'n_clicks'),
    prevent_initial_call=True
)
def add_button_to_card(n_clicks):
    card_idx = ctx.triggered_id['card_number']
    card_children = Patch()
    card_children.append(
        html.Button(
                id={'type': 'button', 'card_number': card_idx, 'index': n_clicks},
                children=f"card{card_idx}_button0"
            )
    )
    return card_children

@callback(
    Output('out', 'children'),
    inputs=dict(
        grouped_buttons=[Input({'type': 'button', 'card_number': card_idx, 'index':ALL}, 'n_clicks') for card_idx in range(1,4)],
        lonely_button=Input('lonely_button', 'n_clicks')
    ),
    prevent_initial_call=True
)
def print_inputs(lonely_button, grouped_buttons):
    return str(ctx.inputs_list)

if __name__ == "__main__":
    app.run_server(debug=True)

Additional context

dash==2.14.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.