allow explicitly picking which props to render in React components
Open
Nobody has claimed this yet.
feature
P3
- Dominant language
- Python
- Stars
- 24.4k
- Forks
- 2.3k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 13
Description
Throughout our React components, we use ramda.omit to filter out props that we wish to exclude from being rendered.
We should invert this by using ramda.pick to include the props that we do wish to render.
This will prevent us from accidentally sending props to be rendered in HTML.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching the React components for uses of ramda.omit and identify the props currently excluded before rendering. Define the explicit renderable-prop lists for each affected component, then verify that intended HTML props still render and other component props are not passed through.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100