remove duplication in application runner structure within Dash testing framework
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 24.4k
- Forks
- 2.3k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 13
Description
We currently repeat ourselves a bit within the the application runners (RRunner and JuliaRunner) -- we should consider 🌴 these up a bit, and call ProcessRunner._start_command instead. We could refactor such that we use self.__class.__name__ within the logger, with a command template string. That would enable us to collapse the logic into a single function.
@alexcjohnson @waralex
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the RRunner, JuliaRunner, and ProcessRunner definitions in the Dash testing framework, then compare their startup logic with ProcessRunner._start_command. Confirm the existing runner tests before consolidating the duplicated logic; done means both runners use the shared startup path without changing their logged commands or behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, r
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100