Add correct test for warnings logged in restricted iframes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 24.4k
- Forks
- 2.3k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 13
Description
Describe your context
Please provide us your environment so we can easily reproduce the issue.
- replace the result of
pip list | grep dashbelow
dash 1.8.0
dash-core-components 1.7.1
dash-html-components 1.0.2
dash-renderer 1.2.3
dash-table 4.6.0
-
if frontend related, tell us your Browser, Version and OS
- OS: All
- Browser: All
Describe the bug
With the change in https://github.com/plotly/dash/pull/1080 to allow usage within restricted iframes, we also do a somewhat poor job of checking the type of the warnings logged.
Expected behavior
We should check the exact error string if possible, or at least check for the existence of a specific substring.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #1080 and the existing test for warnings logged when Dash runs in restricted iframes. Identify how the test currently checks the warning type, then make the assertion verify the exact error string or a specific substring. Done means the test rejects unrelated warnings while passing for the expected warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100