Expose `ended` property
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 81
- Forks
- 17
- Avg merge
- 7d 1h
- Merged PRs (30d)
- 2
Description
react-player provides onEnded that is useful for doing things when the video is done playing. DashPlayer should expose an ended property that is True when the video has finished playing. I can do a workaround by comparing the currentTime to the duration but in my opinion it's not the best workaround because the callback fires every n milliseconds when using the currentTime as an Input, whereas it could just fire once if ended was exposed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the DashPlayer component and its React-Player integration to find where exposed playback properties are defined. Confirm that an ended property reports true when the video finishes and that the behavior is covered by the repository's existing validation or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100