plotly / plotly/choreographer

Can close logger-pipe faster

Open
#259 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
17
Forks
10
Avg merge
4h 56m
Merged PRs (30d)
4

Description

When you pass the write pipe to Popen to catch its stderr to logs, you can immediately close the pipe- your Popen process has already opened it, it will be preserved.

This way, you don't have to do it during close(), which is already complex enough.

In general, all Popen calls can be set to bias against passing unneeded pipes and needed pipes can be passed explicitly to reduce kernel resource leaks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Popen calls that pass pipes and the logger-pipe close() path. Review how the process preserves its opened pipe and identify which needed pipes must remain explicit. Done means unnecessary pipes are closed earlier without leaving needed streams unavailable or increasing resource leaks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, operating-systems
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.