Giraffe.ViewEngine.StrongName breaks compatability with Giraffe server
Nobody has claimed this yet.
- Dominant language
- F#
- Stars
- 860
- Forks
- 99
- Avg merge
- 22m
- Merged PRs (30d)
- 1
Description
Description
Hey, thanks for you effort in this library, it really is amazing.
I came about an issue with the fork project mentioned here https://github.com/giraffe-fsharp/Giraffe.ViewEngine/issues/23
It is currently not possible to render a chart to json in a giraffe backend via toJson gChart as it was added in version 4.1.0 which doesn't work with giraffe due to a presence of forked Giraffe.ViewEngine.StrongName package
Components.fs(286,9): error FS0001: All elements of a list must be implicitly convertible to the type of the first element, which here is
'Giraffe.ViewEngine.HtmlElements.XmlAttribute (Giraffe.ViewEngine.StrongName, Version=2.0.0.0, Culture=neutral, PublicKeyToken=028aa8e2a326f4d0)'.
This element has type 'Giraffe.ViewEngine.HtmlElements.XmlAttribute (Giraffe.ViewEngine, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null)'.
[Components.fsproj::TargetFramework=net8.0]
Repro steps
dotnet new giraffe -o plot
cd plot
dotnet add package Plotly.Net
dotnet build
Expected behavior
Project builds
Actual behavior
/home/a/projects/plot/Program.fs(57,14): error FS0001: This expression was expected to have type 'Giraffe.ViewEngine.HtmlElements.XmlNode (Giraffe.ViewEngine, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null)' but here has type 'Giraffe.ViewEngine.HtmlElements.XmlNode (Giraffe.ViewEngine.StrongName, Version=2.0.0.0, Culture=neutral, PublicKeyToken=028aa8e2a326f4d0)' [/home/a/projects/plot/plot.fsproj]
Build FAILED.
Known workarounds
Fork Plotly.Net and revert the change
Related information
- Operating system Linux
- Branch v4.1.0+
- dotnet 8.0.204
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported build failure with the Giraffe template, Plotly.Net 4.1.0 or newer, and the dotnet 8.0.204 environment described. Inspect the dependency versions behind Components.fs line 286 and Program.fs line 57; done means the sample project builds without the Giraffe.ViewEngine versus Giraffe.ViewEngine.StrongName type mismatch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fsharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100