plotly / plotly/Kaleido

Investigate use of asyncio-timeout in dev/testing

Open
#290 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
498
Forks
62
Avg merge
1d 11h
Merged PRs (30d)
2

Description

related to https://github.com/plotly/Kaleido/issues/260

Since we support python >=3.8, and because python has very rapidly updated asyncio since then, we are in a weird space where sometimes we use a deprecated library.

We have traditionally used it in testing when building automatically expiring fixtures in conftest, but we may be able to refine kaleido's particular dependencies depending on what tests we do write or plan on writing, or maybe even eliminate it with asyncio's wait_for.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the testing setup in conftest and inspect how automatically expiring fixtures use asyncio-timeout. Review the related issue and the tests that need such fixtures, then compare the existing dependency with asyncio.wait_for. Done means reaching and documenting a clear dependency decision supported by the planned or existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.