plone / plone/plonecli

Please Add Option To Skip Venv Creation

Open
#83 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
20
Forks
12
PR merge metrics
No merged PRs in 30d

Description

  • Plone CLI version: 2.5
  • Python version: 3.11.2
  • Operating System: Debian Bookworm amd64
Description

I want to get a Plone6 development environment set up, using my 'plone6' virtualenv which I manage with 'virtualenvwrapper'.

What I Did
(plone6)$ plonecli build

This created a subdirectory 'venv' in the project directory and pulled all sorts of stuff into that, as opposed to just using the already existing and activated virtualenv. I found no way to prevent this from happening. The weirdest thing is, this happened on one machine. On another machine of mine, which runs the same operating system, and where I ran this initially, it did use the virtualenv, but after rsync'ing the resulting project and virtualenv to this machine, it still started with creating that 'venv' directory and put everything that was already present, in there as well. With the scripts being configured in a way that the virtualenv isn't even relocatable, I see no benefit at all, besides not wanting this stuff in my project directory.

Please add a mechanism to use an existing virtualenv and skipping the 'venv' creation step.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the plonecli build command and trace where the project-local venv is created and selected. Define how an already activated virtualenv should be detected or selected, then verify that building with an existing virtualenv does not create a venv directory and still installs the project requirements correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.