plone / plone/plone.testing

zserver uses asyncore, which is gone in Python 3.12

Open
#103 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3
Forks
9
Avg merge
2d 3h
Merged PRs (30d)
3

Description

I just noticed this because depencencychecker complains about a missing dependency on asyncore.

On Python 3.11, when I import asyncore I get:

DeprecationWarning:
The asyncore module is deprecated and will be removed in Python 3.12.
The recommended replacement is asyncio

See also the Python docs.

I don't know if we can simply search-and-replace, or need to do more. But ZServer itself is not supported anymore. Our zserver.rst tests only get run if import ZServer succeeds, which it does not.

So we should probably deprecate/remove it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the zserver.rst tests and the import ZServer condition that controls whether they run. Check how asyncore is used and determine whether ZServer support should be deprecated or removed, then update the affected tests and documentation. Done means the test suite no longer depends on asyncore or silently skips the ZServer coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.