The generated secret is not persisted when not using keyring
Open
@buchi is already working on this.
Since Jul 23, 2020.
- Dominant language
- Python
- Stars
- 109
- Forks
- 107
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
def _signing_secret(self):
if self.use_keyring:
manager = getUtility(IKeyManager)
return manager.secret() + self._path()
if not self._secret:
self._secret = GenerateSecret()
return self._secret + self._path()
The code should be like:
def _signing_secret(self):
if self.use_keyring:
manager = getUtility(IKeyManager)
return manager.secret() + self._path()
if not self._secret:
self._secret = GenerateSecret()
self._p_changed = True
return self._secret + self._path()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.