What is the create parameter meant for in DeserializeFromJson.__call__?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 109
- Forks
- 107
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
... a create parameter is given without any documentation. The IDeserializeFromJson also defines nothing here. In fact, when create=True is passed nothing is "created" (which in fact would be difficult, because the adapted content is expected to be the target object above while validating) and deserialization is stripped down to validation only, no content is set. except layout and ordering.
Overall this is really confusing and does not make any sense at all.
cc @tisto
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/plone/restapi/deserializer/dxcontent.py at lines 38-40 and inspect the IDeserializeFromJson definition referenced in the issue. Trace the create=True path to confirm its validation-only behavior and determine the intended semantics before deciding whether the parameter needs documentation or clarification. Done means the parameter's purpose and effects are unambiguous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100