plone / plone/plone.restapi

Log warning if field in a POST/PUT call does not exist

Open
#511 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

04 type: enhancement 05 type: question
Dominant language
Python
Stars
109
Forks
107
Avg merge
2d 3h
Merged PRs (30d)
4

Description

plone.restapi performs a good validation (or the field validation does it). However plone.restapi does not check for the existence of a field. So you can send 'foo': 'bar' as part of patch request. Perhaps it would make sense to check if field foo really exists and report this as an error?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the POST/PUT and PATCH field-validation entry points in plone.restapi, then trace how unknown fields are handled. Reproduce a request containing the 'foo' field and define done as reporting that the field does not exist, with coverage for the resulting warning or error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.