Query params checking often do not allow for negated values
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 109
- Forks
- 107
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
For example /@search?fullobjects=0 doesn't work as we currently on check for the existence of the key.
A better pattern would be:
param = bool(query.pop('param_name', False))
if param:
# do stuff
We'd like to support something like:
?fullobjects -> True
?fullobjects=1 -> True
?fullobjects=true -> True
?fullobjects=0 -> false
?fullobjects=false -> True
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the query-parameter handling described in the issue and the code shown in the referenced commit. Trace how presence-only parameters and values such as 0, 1, true, and false are interpreted, then add or update coverage for the requested behavior and verify the REST API tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100