Registering the expandable elements as adaptors defeats the purpose if the service instantiates them directly
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 109
- Forks
- 107
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Description
It would be better if the service calls the navigation as an expandable element. This allows overriding the expandable element once without having to also override the navigation service.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/plone/restapi/services/navigation/get.py around line 193, where the navigation service instantiates the expandable elements. Trace how the navigation is currently obtained and how expandable elements are registered as adaptors. Done means the service calls the navigation as an expandable element, allowing that element to be overridden without also overriding the navigation service.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100