File download link doesn't include filename
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 42/100
Research direction
Start at src/plone/restapi/serializer/dxfields.py line 121 and compare the REST API download URL with the linked plone.app.contenttypes template at line 13. Trace the file-download serialization and update the generated link so it includes the filename, then verify that both download access and the caching purge behavior remain covered.
Written by the indexing model from the issue text.
Description
In Plone the download link usually contains the filename at the end.
This has the advantage a user copying the link gets a neat filename on the fs, i.e. when using low level tools like wget.
Not so in restapi
I consider this inconsistency a regression.
In practice this has an impact on plone.the purging in app.caching. The URL without the filename at the end wont be purged.
I'll fix this in plone.app.caching to purge all ways to access a file download
https://github.com/plone/plone.app.caching/pull/71
But in the end we loose the feature of good filenames on download if not changed here.
- Dominant language
- Python
- Stars
- 109
- Forks
- 107
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plone/plone.restapi
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
plone/plone.restapi#2031 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
plone/plone.restapi#662 · 2 comments · 4 reactions ·
-
01 type: bug
plone/plone.restapi#2023 · 1 comment · 1 assignee ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
plone/plone.restapi#2017 ·
-
@controlpanels/content-rules/<rule>/action/<idx> omits values for fields in non-default fieldsets Open
plone/plone.restapi#2016 · 1 assignee ·
All issues in plone/plone.restapi
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100