plone / plone/plone.behavior

AnnotationStorage superfluous?

Open
#5 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

03 type: feature (plip) 23 status: testing
Dominant language
Python
Stars
3
Forks
3
Avg merge
1d 13h
Merged PRs (30d)
3

Description

The complete implementation here is unused:
https://github.com/plone/plone.behavior/blob/master/plone/behavior/annotation.py

The only place ist used is a test case here.
https://github.com/plone/plone.app.versioningbehavior/blob/master/plone/app/versioningbehavior/tests/test_modifiers.py#L92

I propose to move annotation.[py|rst] to a testing [py|rst] - thats what its used for - and the whole code is less confusing afterwards.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading plone/behavior/annotation.py and its accompanying annotation.rst, then inspect the usage in plone/app/versioningbehavior/tests/test_modifiers.py around line 92. Confirm that the implementation is only used by that test case. Done means moving the annotation files into testing equivalents without leaving the test dependency or documentation references broken.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.