plone / plone/plone.app.testing

Warn if developer tries to commit transaction in an integration testing layer

Open
#6 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2
Forks
7
Avg merge
1d 11h
Merged PRs (30d)
3

Description

Tell them to use a functional layer instead.

We can do this by patching transaction.commit or by adding a transaction resource manager that always fails on commit. Whatever we set up in the integration layer, the functional layer needs to take down.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating how the integration testing layer configures transactions and how the functional layer tears that setup down. Review the existing transaction handling before choosing between the approaches described in the issue; done means an attempted commit is warned about or prevented in integration tests without affecting functional-layer cleanup.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.