plone / plone/plone.app.robotframework
Deprecate "I'm logged in as..."?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 11
- Forks
- 17
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 2
Description
We currently have two ways of defining a precondition for a logged in user:
I'm logged in as a 'Site Administrator'
or
a logged in site administrator
Both keywords use past tense, which is considered best practice for GIVEN keywords in BDD. Though, the "I do something" is usually reserved for WHEN keywords to indicate an action of a user. Therefore if we want to use this keyword in GIVEN, we should stick to the second option and deprecate the first option to avoid confusion. What do you think @datakurre?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue discusses two alternative logged-in-user precondition keywords in the Robot Framework resources, but it names no file or test entry point. First clarify whether the "I'm logged in as..." keyword should be deprecated; done would require an agreed deprecation path and updated coverage for the remaining form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100