plone / plone/plone.app.robotframework
Wrong selector in `Open Menu` keyword
Open
Nobody has claimed this yet.
01 type: bug
02 type: regression
- Dominant language
- Python
- Stars
- 11
- Forks
- 17
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 2
Description
This markup is no longer in sync with Plone 6 menu, where there is no div ancestor for ul.
This is the markup of plone-contentmenu-factories for example :
<div class="pat-toolbar initialized" id="edit-zone" role="toolbar" data-bs-scroll="true">
...
<ul>
<li class="plonetoolbar-contenttype dropend"
id="plone-contentmenu-factories">
<a class="nav-link dropdown-toggle show"
aria-expanded="true"$
href="https://classic.demo.plone.org/en/folder_factories?_authenticator=3df290c2b5a2bdc2bff0851ba265fbf037d77b28"
data-bs-offset="0,0"
data-bs-toggle="dropdown"
title="Add new items inside this item">
<span class="toolbar-label">Add new… </span>
</a>
<ul class="dropdown-menu show"
style="position: absolute; inset: 0px auto auto 0px; margin: 0px; transform: translate3d(220px, -225px, 0px);"
data-popper-placement="right-start">
<li>
<h6 class="dropdown-header">
Add new…
</h6>
</li>
...
<li>
<a class="nav-link dropdown-item contenttype-collection"
href="https://classic.demo.plone.org/en/++add++Collection"
title=""
id="collection">
Collection
</a>
</li>
...
</ul>
</li>
...
</ul>
</div>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/plone/app/robotframework/keywords.robot at lines 121-124 and inspect the Open Menu keyword's selector against the Plone 6 markup shown in the issue. Run the relevant functional Selenium/Robot Framework tests, and consider the work done when Open Menu locates the menu without relying on a div ancestor for ul.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100