plone / plone/plone.app.querystring
How should we handle types that are global_allow=False in queries in collections? (Plone 4.3.x)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 25
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 2
Description
I'm posting this issue here and in plone.formwidget.querystring, feel free to close if inappropriate.
We're using https://github.com/collective/collective.nitf instead of Plone's "News Item" content type, and decided to set "Implicitly addable" (global_allow) to False in "News Item" portal_types. For the sake of usability/familiarity of the user with Plone naming, we decided to rename in a policy product the nitf items to "News Item" as if it was Plone's. So far, so good.
But now we're having some usability problems when adding a collection, since both "News Item" are being shown in the select field (In Brazilian portuguese, "Noticia" is the same as "News"):

I know that from a programatic POV this is correct (they are both valid in portal_types), but not from an user perspective: if I can't add the "News Item" anywhere in the site since I set "Implicity addable" to false, why it's being shown here?
I'm not familiar with the code, but what defines what types should be shown in the select? Is it possible to add somewhere to not use items which global_allow is False, or to take into consideration types_not_searched in portal_properties? I tried to add "News Item" to types_not_searched but it didn't work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are identified in the issue. Start by tracing the code that builds the collection type select, then inspect how portal_types global_allow and portal_properties types_not_searched are handled. Done means types that cannot be added, or are excluded from search, no longer appear in the select.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- search
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100