plone / plone/plone.app.querystring
custom search pages don't act like /@@search due to munge_search_term
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 25
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 2
Description
Now that volto allows creating custom search forms it doesn't make sense that we should be using .contains for this as it does things like add a wildcard to the end of the char and prevent
- see https://github.com/plone/plone.app.querystring/blob/f8bfbfa814d63fda9bef94d79dc88f55235eaf58/plone/app/querystring/querybuilder.py#L204
- and https://github.com/plone/plone.app.search/blob/master/plone/app/search/browser.py#L22
I think there should be a new .string.search operator which does the same kind of processing as @@search does.
e.g. not add a wildcard to the end and not put AND operator in
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced querybuilder.py line 204 and plone/app/search/browser.py line 22 to compare the existing query processing with @@search. Add the proposed .string.search operator so it does not append a wildcard or insert an AND operator, then verify custom search forms follow the same behavior as @@search.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- search
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100