plone / plone/plone.app.querystring

query-string search should work with vocabulary token instead of value

Open
#108 0 comments 0 reactions 1 assignee View on GitHub

@jackahl is already working on this.

Since May 5, 2022.

04 type: enhancement
Dominant language
Python
Stars
2
Forks
25
Avg merge
1d 16h
Merged PRs (30d)
2

Description

As the vocabulary in a token is the proper unique identifier for that term it should be the thing that is stored in in the volto frontend. Currently querystring uses the value of that term to assemble the search, which potentially could lead to issues as these can theoretically be of datatypes that are not reasonable to store in the frontend (e.g. python objects). Therefor especially when used with restapi and volto querystring searches should mostly rely on the vocabulary token.

The prerequisites to implement this are already available in #107.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.