Rework generating userid in user.create
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 101
- Forks
- 62
- Avg merge
- 15h 15m
- Merged PRs (30d)
- 1
Description
As @mauritsvanrees pointed out in https://github.com/plone/plone.api/issues/270#issuecomment-131858100 .
See https://github.com/plone/plone.app.users/blob/2.3/plone/app/users/browser/register.py#L137
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in issue #270 and inspect plone/app/users/browser/register.py around line 137. Trace how user.create currently generates the userid and determine the intended replacement behavior from that context. Done means the userid generation has been reworked consistently with the agreed approach, with relevant tests updated or added if identified during the investigation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100