plone.api.get_roles(username=userid) breaks if username != userid
Open
Nobody has claimed this yet.
01 type: bug
- Dominant language
- Python
- Stars
- 101
- Forks
- 62
- Avg merge
- 15h 15m
- Merged PRs (30d)
- 1
Description
When use with collective.emaillogin4, userid can be different from username.
So the api should be
plone.api.user.get_roles(userid=None, user=None, obj=None, inherit=True)
not
plone.api.user.get_roles(username=None, user=None, obj=None, inherit=True)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating plone.api.user.get_roles and any tests or callers for its username parameter. Verify the API accepts userid instead, while preserving the existing user, obj, and inherit behavior, and update coverage to confirm calls work when userid differs from username.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100