plone / plone/mockup

Live Search: Enter key does not trigger search

Open
#878 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

41 lvl: easy
Dominant language
JavaScript
Stars
57
Forks
103
Avg merge
10h 25m
Merged PRs (30d)
18

Description

You can test this on the demo page. Type something like "news" in the live search input and press enter. You get a 404 - it tries to load a search page that does not seem to exist. Instead I would expect it to do a live search as if you had just stopped typing.

It looks like the enter key triggers the submit event on the form. Catching it and preventing any actions will probably fix this issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the linked live-search demo page and trace how the search form handles Enter and the live-search input events. Done means pressing Enter performs the same live search as stopping typing, without submitting to the 404 search page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, search
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.