`pat-upload` event when all uploads are completed
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 103
- Avg merge
- 10h 25m
- Merged PRs (30d)
- 18
Description
I though that uploadAllCompleted event tells me, that all uploads are completed -> wrong 🤔
Since this event gets triggered on Dropzone.success, its fired after each uploaded file. The correct event would be Dropzone.queuecomplete. But with this event you do not have the data of the uploaded files. This needs investigation who uses uploadAllComplete and how ... currently greping mockup shows, that its not used at all, since tinyce now has the contentbrowser.
Mainly this is "just" a documentation issue, because all pat-uploadoptions get injected into Dropzone so you can simply use data-pat-upload="queuecomplete: my_complete_function" and register it as window.my_complete_function somehwere in your code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the pat-upload documentation and searching the repository for uploadAllCompleted and queuecomplete usages. Document that uploadAllCompleted fires after each successful file, and show how to configure Dropzone's queuecomplete event through pat-upload; confirm the documented option matches the available behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- Half a day
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100