plone / plone/mockup

make serve missing bundle without first running build:webpack:docs

Open
#1,386 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
57
Forks
103
Avg merge
10h 25m
Merged PRs (30d)
18

Description

make install && make serve result in 404 errors for http://localhost:8001/dist/mockup/bundle.min.js (on any supported node version I have tried).

There is not any output to _site/dist/mockup directory (which does not exist without webpack told to output to this target directory via npx yarn run build:webpack:docs).

If the interactive documentation is the primary vehicle for someone to develop and test basic changes to patterns (in a simpler vacuum outside of plone.staticresources), it might make sense to either:

  1. Update Makefile(s) to include this by default as a dependency of make serve as some (new) bundle-docs target?
  2. Update README.md development section to mention this is an explicit additional step needed to "run" the documentation?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running make install && make serve and inspect the resulting 404 for _site/dist/mockup/bundle.min.js. Read the Makefile(s), the build:webpack:docs target, and the development section of README.md; done means the documentation workflow either serves the bundle by default or clearly documents the required step.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, webpack
Domain
build-system, documentation
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.