plone / plone/mockup

How to set default modal timeout or handle timeouts correctly?

Open
#1,363 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
57
Forks
103
Avg merge
10h 25m
Merged PRs (30d)
18

Description

Sometimes we see "error happened timeout do something" messages in Browser Console after clicking "Save" on a modal. We are wondering if it is possible to increase the default value of 5000 which is set here . It is far to low for us b/c diazo is sometimes very slow.

Or maybe we need to handle it in some way, b/c there is options.onTimeout here ?

We hit the timeout while editing values in portal registry using /portal_registry view and while editing properties of pages and folders which have a mosaic layout.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/pat/modal/modal.js at the 5000ms timeout and the options.onTimeout handling referenced by the issue. Reproduce the timeout while saving the portal registry or Mosaic page properties, then determine whether the default timeout or timeout handling should change; done means slow saves no longer produce an inappropriate timeout message.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.