Accessibility Issue accessing tabs in a model with the keyboard
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 103
- Avg merge
- 10h 25m
- Merged PRs (30d)
- 18
Description
Hi, while testing some keyboard navigation related stuff on plone.app.mosaic I noticed that it is impossible to access tabs in their 'Properties' Modal.
It seems the 'keydown' Listener on a modal form ( see modal.js#L444 ) prevents the on click event to fire, which would trigger the tab change.
Because field sets as tabs are such a common thing in Plone I think this should work.
I don't fully grasp the function of the aforementioned keydown listener, but maybe there should be testet if the target is actually a form Element.
Maybe something like: || ! ['INPUT','SELECT','BUTTON (?!) '].includes(event.target.nodeName)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/pat/modal/modal.js around line 444 and reproduce keyboard navigation in the Properties modal, where the keydown listener prevents tab activation. Trace the listener's purpose and verify that field-set tabs can be reached and changed with the keyboard without breaking modal behavior. Done means the tabs are accessible from the keyboard.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100