Non-unique ids in Theming Controlpanel
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 103
- Avg merge
- 10h 25m
- Merged PRs (30d)
- 18
Description
The "Theming Controlpanel" (aka. "Theme settings") has two levels of nav-elements with non-unique ids.
-
- level:
autotoc-item-autotoc-0,autotoc-item-autotoc-1
- level:
-
- level:
autotoc-item-autotoc-0,autotoc-item-autotoc-1,autotoc-item-autotoc-2
- level:
The given anchors are also non-unique (see href attributes). It is not possible to properly access the elements via a url with anchor.
I'd suggest to change the 2. level ids to something like autotoc-item-autotoc-1-0, autotoc-item-autotoc-1-1, autotoc-item-autotoc-1-2
In which repository should I post an issue?
For more details and an image see this issue and the comments.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Theming Controlpanel, also called Theme settings, and the code that generates its two levels of nav elements and anchors. Reproduce the duplicate IDs and href targets shown in the issue; done means every generated ID and corresponding anchor is unique and nested headings remain directly addressable by URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100