plepe / plepe/OpenStreetBrowser

Classification

Open
#86 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
113
Forks
22
PR merge metrics
No merged PRs in 30d

Description

A few comments about classification

1/
Tourist information panels (see board and board_type ) shouldn't be in "Services > Tourism" menu as they are not exactly services.
I think they should be in "Culture and Religion > Tourism"
It makes more sense to me.

2/
In "Services > Communication" I see "post box" and other things mixed with some "offices" (newspaper, publisher or company from the ICT sector,...)
I think I understood what you wanted to do: use "communication" as a thematic
In my opinion it doesn't work well.

  • A post box is an urban amenity
  • A company office is a legal entity that produces or sells services
    These are two very different things.
    These offices (telecommunication, it, newspaper, publisher, advertising_agency, public_relations,audiovisual_production, film_production) should be in "Services > Offices"

Perhaps you can create some sub categories in Offices.
Examples :
Communication :

  • public_relations
  • human_resources
  • communication_agency
  • advertising_agency
  • ...

Audiovisual :

  • audiovisual_production
  • film_production
  • ...

Press / Edition :

  • newspaper
  • publisher

And so on ....
We've talked about that >>> https://github.com/plepe/openstreetbrowser-categories-main/issues/25#issuecomment-443533781

And I think that "Law" and "Financial" should be in "Services > Offices" too

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation files or tests are named. Start by reviewing the category definitions and the linked OpenStreetMap pages, then read the discussion referenced from categories-main issue 25. Done means reaching an agreed classification and updating the menu so tourism, communication, offices, law, and financial categories follow that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.