playframework / playframework/twirl
compileVirtual should not depend on `File` object to template
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 561
- Forks
- 118
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 29
Description
I think TwirlCompiler.compileVirtual should not depend on File object to template because internally it's used only to generate template name. This prevent clients from compiling twirl templates on the fly. In my case I'd like admins of web-service to be able to update templates via API which are stored in DB.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at TwirlCompiler.compileVirtual and trace how the File object is used to generate the template name. Completion means templates supplied from a database or another non-File source can compile while retaining a usable template name; the issue names no tests, so identify coverage for this entry point.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100