playframework / playframework/twirl

Make multiple argument lists useful

Open
#110 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status:backlog
Dominant language
Scala
Stars
561
Forks
118
Avg merge
1d 15h
Merged PRs (30d)
29

Description

The only situation where you really need multiple argument lists is for path-dependent argument types but this breaks Twirl's translation scheme because argument lists have to merged to implement play.twirl.api.TemplateX. An obvious fix would be not to extend a TemplateX class or generate a render method when multiple argument lists are used.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Twirl's translation scheme for multiple argument lists and how it implements play.twirl.api.TemplateX. Compare the generated behavior for path-dependent argument types with the proposed handling of TemplateX inheritance and the render method; done means multiple argument lists work without breaking translation.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
tooling
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.