playframework / playframework/twirl
Support `@implicit ...` keyword
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 561
- Forks
- 118
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 29
Description
Now that we support @var, @val, @lazy val it makes sense IMHO to also support
@implicit var@implicit val@implicit lazy val@implicit foo(defcalledfoo)
instead of requiring values and variables to be prefixed with like @val implicitSomeVar (like we do now).
Should not break anything since implicit is a scala keyword and could not be used in twirl until now anyway.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing handling of @var, @val, and @lazy val in Twirl, along with tests for those forms. Extend the same entry points to cover @implicit var, @implicit val, @implicit lazy val, and @implicit foo, while confirming the existing forms remain unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100